eclipse-aascw / aas-core-codegen / 36634104500

90%

Build Type

push

github

Committed by web-flow

Commit Message

Transpile sets of primitives (#796)

We transpile the local sets, the set arguments and the operations on
sets, so that the meta-model can, *e.g.*, check the uniqueness:

    seen: Set[str] = set()
    for text in texts:
        if text in seen:
            return False
        seen.add(text)

A set holds booleans, integers, strings, constrained primitives of them
or enumeration literals. We refuse the other items, each with its exact
reason, *e.g.*, the floats since the targets disagree on NaN and -0.0.

The arguments are either read-only, ``AbstractSet[T]``, or mutable,
``Set[T]``, just as ``Sequence`` and ``List``, also under ``Optional``.
A set argument must receive a set of the same items, so that we can
pass the constant sets as read-only arguments. The constant sets must
be now declared as ``AbstractSet[...] = constant_set(...)``, and we
migrated all the meta-models accordingly.

We support ``set()``, ``add``, ``in``, ``len``, ``intersection``,
``difference`` and the iteration over a set, where the order of
the items differs among the targets. We refuse to alias a set, as C++
copies it while the other targets share it, and to mutate a set in
the loop over it.

The membership in a set is now a constant-time look-up in C++,
``s.find(x) != s.end()``, also for the constant sets.

The constant sets of enumeration literals in C# now hold non-nullables,
*e.g.*, ``HashSet<KeyTypes>`` instead of ``HashSet<KeyTypes?>``, so
that we can pass them as set arguments. We made them nullable in #248
only because we could not unwrap the narrowed nullables at the time,
which we can now, *e.g.*, ``Contains(that.DataType.Value)``. This breaks
the public API of the C# SDK.

We allow the calls as statements in the nested blocks as well, and fix
the constant sets of booleans, integers and floats in Go, which did not
compile.

The common meta-model ``sets`` covers the feature.

Coverage Stats

500 of 648 new or added lines in 62 files covered. (77.16%)

11 existing lines in 9 files now uncovered.

43612 of 49098 relevant lines covered (88.83%)

2.66 hits per line