supabase / supabase-swift / 36601869583

90%

push

github

fix(auth): preserve status context for non-JSON 5xx errors (#1392)

* fix(auth): preserve status context for non-JSON 5xx errors

APIClient.handleError returned a generic message whenever the body could
not be decoded as _RawAPIErrorResponse, hiding the only actionable context
a non-JSON 5xx response (proxy HTML page, empty body) carries.

HTTPURLResponse does not expose the reason phrase, so the fallback now
uses "HTTP <status>: <status description>" for 5xx responses, where the
description comes from HTTPURLResponse.localizedString(forStatusCode:).
The status code is always included because the description is localized
on Darwin and differs from the Linux one. Non-5xx responses keep the
existing fallback message.

Rebases supabase-swift#1312 onto the AuthError-as-struct and
swift-http-types API changes that landed on main since it was opened.

Fixes #1171

Co-authored-by: Muhammadjon Marufov <marufov254@gmail.com>

* fix(auth): pass the session parameter in APIClientTests.handleError calls

handleError gained a required `for session:` parameter in #1374, which
landed on main after this branch forked from it.

* fix(auth): retain the AuthClient backing APIClientTests' apiClient

apiClient built a throwaway AuthClient inline and only kept its clientID,
so AuthClient's deinit removed the Dependencies entry before handleError
could read it back, crashing with "Dependencies not found for id: N" in
CI's Linux and Mac Catalyst jobs (deinit runs synchronously there, unlike
the other platforms where the temporary lived long enough by chance).

---------

Co-authored-by: Muhammadjon Marufov <marufov254@gmail.com>

13 of 13 new or added lines in 1 file covered. (100.0%)

10782 of 12042 relevant lines covered (89.54%)

891721.14 hits per line