decentraland / worlds-content-server / 36576530024

92%

main: 92%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: answer full partial-upload quotas with 429 and retry-after

The four partial-upload quotas (uploads per account, staged bytes per
account, staged bytes per server, accepted bytes per minute) rejected
with 400, so clients treated a temporary condition as a bad request.
They now throw a typed PartialUploadQuotaExceededError that the deploy
handler maps to 429 with Retry-After; every other 400 stays a 400.

Retry-After, always at least 1 s:
- bytes per minute: until the account's one-minute window resets
- other quotas: until the oldest upload holding that quota expires
  (the account's for the per-account ones, the server's for the global
  one; only uploads with reserved bytes count for byte quotas), or 60 s
  when it has already expired, since only the unscheduled cleanup can
  free it then

Messages state the measured and allowed values.

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

2180 of 2524 branches covered (86.37%)

Branch coverage included in aggregate %.

631 of 660 new or added lines in 37 files covered. (95.61%)

26 existing lines in 5 files now uncovered.

4447 of 4708 relevant lines covered (94.46%)

237.57 hits per line