fyne-io / fyne / 36565429278

61%

develop: 61%

Build Type

Pull #6558

github

Committed by MaxGyver83

Commit Message

Make the keyboard tests respect the platform modifier conventions

The tests hard-coded Control, but the mobile driver mirrors the desktop
driver, which detects its built-in shortcuts with
fyne.KeyModifierShortcutDefault (Command on macOS), and widget.Entry
registers its word selection and word deletion shortcuts with Alt on
macOS instead of Control. The tests therefore failed on macOS.

Use fyne.KeyModifierShortcutDefault in TestShortcutForKey, compare the
custom shortcut names against a CustomShortcut built with the same
modifier instead of hard-coding the modifier name, and use the platform
specific modifiers in the shortcut integration tests.

Pull Request Pull Request #6558: Add Ctrl shortcut and modifier handling to the mobile driver

Coverage Stats

68 of 70 new or added lines in 1 file covered. (97.14%)

4 existing lines in 2 files now uncovered.

24765 of 40797 relevant lines covered (60.7%)

738.36 hits per line