panates / rman / 36555206390

95%

main: 95%

push

github

fix(run): print a failed package's captured log as captured, not in red

The progress panel replays a failed item's whole log under its `X` line, and
wrapped the join in `colors.red()`. That log holds every step the item ran and
only the last one failed, so the steps that *succeeded* were reported as
failures.

Measured on a real build whose `before` ran `rman check` then `rman lint`: check
passed, printed `✅ no circular dependency was found` and `1 succeeded, 0
failed`, and both came back red under the failing package - the reader sees a
block of red and reads the whole thing as the error.

It also corrupts what the steps themselves coloured, because `colors.red()`
wraps the entire string: a line carrying its own colour keeps it up to its reset
and then falls into red for the remainder. Reproduced in isolation -
`1 succeeded, 0 failed` rendered as `\e[31m\e[32m1 succeeded\e[39m\e[31m, ...`,
green up to the comma and red after it.

The `X` header already says the item failed, and the step that failed printed its
own error. The replay is a replay.

The spec for it needed two things to measure anything, both found by running the
negative control and watching it stay green: `colors.enabled` forced on, since
ansi-colors disables itself when stdout is not a TTY and `colors.red(x)` then
returns `x`; and a raw capture, since this file's `captureLogs` strips ANSI.
Either one alone makes the case vacuous.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2894 of 3175 branches covered (91.15%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

17406 of 18386 relevant lines covered (94.67%)

197.08 hits per line