aio-libs / yarl / 36552953552

98%

Build Type

push

github

Committed by web-flow

Commit Message

Read the authority of http:host without "//" in WHATWG mode (#1937)

<!-- Thank you for your contribution! -->

## What do these changes do?

In the default WHATWG mode, `http:example.com/`, `http:/example.com/`
and `http:///example.com/` now parse as `http://example.com/`, as the
WHATWG URL Standard does for the `http`, `https`, `ws`, `wss` and `ftp`
schemes (the "special authority ignore slashes" state). Previously the
text stayed the path of a URL without an authority and printed as
`http:///example.com/`. Userinfo or a port without a host
(`http:@/www.example.com`) is rejected, as for `http://@/x`. `http:`,
`http:/`, `http:?q`, `http://` and `http:///` are kept as they were,
since there is no host to read. An input with `//` is absolute against
any base, as in WHATWG, so `join()` no longer keeps the base host for
`http:///example.com/`.

Against a base with the same scheme, WHATWG resolves the same input as a
relative reference (`http:foo.com` against `http://example.org/foo/bar`
is `http://example.org/foo/foo.com`). `URL.join()` only sees the parsed
reference, so a URL parsed this way keeps its original path in the cache
(and in its pickle state), and `join()` uses it when the schemes match.
RFC 3986 mode is unchanged: it already keeps these URLs without an
authority.

In `tools/conformance/REPORT.md`, 33 rows move from "WHATWG mode differs
from WHATWG, RFC mode follows RFC 3986" to "yarl follows each standard
in its mode" (28 to 61). Four inputs now fail in WHATWG mode without
changing section. Three are `http:\\host\` (a backslash in the authority
is rejected; backslash handling is a separate change). The fourth is
`http:[61:27]/:foo` against an http base, which WHATWG only accepts
relative to the base, while yarl parses the reference alone first. "yarl
differs, RFC 3986 and WHATWG agree" is unchanged.

## Are there changes in behavior for the user?

Yes. In WHATWG mode, `URL("http:example.com/")` has host `example.com`,
and `URL("http:@/x")` r... (continued)

Coverage Stats

97 of 194 branches covered (50.0%)

Branch coverage included in aggregate %.

134 of 140 new or added lines in 4 files covered. (95.71%)

1 existing line in 1 file now uncovered.

8953 of 9076 relevant lines covered (98.64%)

0.99 hits per line