supabase / supabase-flutter / 36549440608
94%

DEFAULT BRANCH: main
Ran
Jobs 11
Files 171
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.226%. Remained the same
36549440608

push

github

web-flow 
fix(typegen): suffix a schema object named ArgumentError so the generated enums compile (#1893)

## What

Adds `ArgumentError` to the identifiers `_TypeNameRegistry` reserves, so
a schema object named `argument_error` is emitted as `ArgumentError$`
like every other name that would shadow something the generated file
references unqualified.

## Why

The registry seeds `_used` with every identifier the generated source
references without a prefix (`Object`, `Map`, `List`, `Uint8List`,
`Never`, the `Postgrest*` types, ...) so a schema object cannot shadow
it. `ArgumentError` is missing from that list, but `_writeEnum` writes
`orElse: () => throw ArgumentError.value(` into every generated enum's
`fromWire`.

With an enum (or a table, which becomes a namespace class) named
`argument_error`, the generated file declares its own `ArgumentError`
and every enum in the file stops compiling:

```
enum ArgumentError {
  ...
    orElse: () => throw ArgumentError.value(
                        ^ Error: Enums can't be instantiated.
```

The existing test "schema names shadowing core or imported types are
suffixed" pins this contract for `String` and `PostgrestTable`; this is
the one reference that slipped through. I checked the goldens for other
unqualified identifiers and `ArgumentError` is the only one absent from
the registry.

## Not a breaking change

Only a schema object literally named `argument_error` changes its
generated name, and that output did not compile before.

## Tests

`packages/supabase_typegen/test/dart_generator_test.dart`: `an enum
named like the error the parser throws is suffixed`, next to the
existing shadowing test. Fails on `main` (`does not contain 'enum
ArgumentError$ '`) and passes with the fix. `dart test -j 1`: 186
passed, 1 skipped (the same skip as `main`). `dart format -l 80
--set-exit-if-changed` on the changed files and `dart analyze
--fatal-infos .` are clean. No backend needed.


<!-- This is an auto-generated comment: release n... (continued)

8796 of 9642 relevant lines covered (91.23%)

4.95 hits per line

Jobs
ID Job ID Ran Files Coverage
11 supabase_typegen - 36549440608.11 24
95.58
GitHub Action Run
4 supabase_realtime - 36537528666.4 13
90.66
GitHub Action Run
2 yet_another_json_isolate - 35608843571.2 1
98.44
GitHub Action Run
8 supabase_common - 35998092270.8 22
87.5
GitHub Action Run
5 iceberg - 36537528666.5 6
68.52
GitHub Action Run
7 supabase_storage - 36537528666.7 9
97.83
GitHub Action Run
9 supabase_functions - 36537528666.9 4
96.0
GitHub Action Run
8 postgrest - 36537528666.8 28
94.17
GitHub Action Run
3 supabase - 36537528666.3 18
93.71
GitHub Action Run
6 supabase_flutter - 36537528666.6 14
78.5
GitHub Action Run
10 supabase_auth - 36537528666.10 32
92.06
GitHub Action Run
Source Files on build 36549440608