solidjs / solid / 36546409914

74%

main: 89%

push

github

feat(observe): the "request" record — a server-function request left, at the send (#3708)

* feat(observe): the "request" record — a server-function request left, at the send

The "call" record is delivered at settle, so a network panel (solid-start-
devtools) reading it alone cannot show a call that is still in flight, or
one that never settles. The "request" record is the pending row: one per
server-function request the browser SENT, delivered from the transport's
send — after argument serialization and prepareRequest, immediately before
the configured fetch receives the final address and init.

Shape (`CallRequestEvent`, on `HostRecordTypes` beside "call"):
`{ side: "client", id, name?, at, method: "GET" | "POST", origin? }` — id,
name, method and origin by CallEvent's rules (origin the same object, read
at dispatch); `at` is performance.now() at the send, not the call's
dispatch (CallEvent.at is when the call was made; the gap is what building
the request cost). `side` is the client's today; the server half (the
request arrived, ahead of its "invocation") is additive later, as on
"frame". Named `CallRequestEvent`, not `RequestEvent`: that name is the
server request-scope event (`InvocationLive.event`), exported from both
entries already.

Live identity is the join: `observeCall` now creates ONE `CallLive` at the
observation's start (`{ args }`), sets `live.request` at the send and
`response`/`result`/`error` at settle onto the same object — the "request"
listener's live IS the "call" listener's live, by identity, so a consumer
joins them with no id-plus-time match and no sequence number. Documented
on `CallLive` as a guarantee.

Gating, every gate read once at the call's start: the observation exists
when observed("call") || observed("request"); "request" is emitted only
under observed("request"), "call" only under observed("call") (explicit
now — a "request" listener alone gets no settle record, nor does a "call"
listener that arrived mid-call). ... (continued)

625 of 912 branches covered (68.53%)

Branch coverage included in aggregate %.

920 of 1181 relevant lines covered (77.9%)

27.1 hits per line