node-opcua / node-opcua / 36537662309

91%

Build Type

push

github

Committed by erossignon

Commit Message

fix(address-space): answer a refused HistoryRead once

When canUserReadHistory() refused the session, _historyRead called back
with BadUserAccessDenied and then fell through into the read itself, so
the history was read anyway and the callback fired a second time. Return
right after the refusal.

The regression test refuses the read on a historizing variable and checks
the callback fires exactly once, with BadUserAccessDenied.

Coverage Stats

24693 of 29936 branches covered (82.49%)

1 of 1 new or added line in 1 file covered. (100.0%)

150 existing lines in 3 files now uncovered.

204960 of 223230 relevant lines covered (91.82%)

203177.48 hits per line