panates / rman / 36540284663

95%

main: 95%

push

github

fix(publish): ask the registry a package actually publishes to

A repository publishing some packages to GitHub Packages and others to npmjs.org
states it per package, in `package.json`'s `publishConfig.registry`. `npm publish`
honours that - it survives into the generated manifest, since
derivePublishManifest deletes only `publishConfig.directory` - but **`npm view`
does not**, and the registry check read only `--registry`, one value for the
whole run.

Measured, both halves: a package whose `publishConfig.registry` pointed at
http://127.0.0.1:1/ was still answered from registry.npmjs.org, while
`npm view @foo/bar` under `@foo:registry=http://127.0.0.1:1/` did try that
address. So the scoped `.npmrc` case - the usual GitHub Packages setup - always
worked, and the per-package one silently did not.

What that cost: npmViewPackage swallows a failed lookup as `undefined`, which
reads as "never published", so the plan proposed a publish on **every** run - the
first succeeded and the second was rejected by the registry for republishing a
version, failing a release job for no reason of its own. Worse where some other
package holds that name on npmjs.org: rman then reads a stranger's version list
and can report `up-to-date` for a publish that never happened.

`resolveRegistry` resolves it per package, in npm's own precedence, measured
against npm rather than assumed: `publishConfig` alone publishes to it, and
`--registry` beside it wins. With neither given it returns `undefined` and
nothing is passed - which is the half that keeps the working case working, since
an explicit `--registry` would override whatever `.npmrc` says.

Only the check needed changing. `applyPlan` already passes `--registry` only when
given, and npm reads `publishConfig.registry` out of the manifest it publishes -
`--dry-run` reports `Publishing to https://from-publishconfig.example/`.

Three specs, pinned on the argv because that is the only place the difference
exists, with a negative... (continued)

2891 of 3170 branches covered (91.2%)

Branch coverage included in aggregate %.

47 of 47 new or added lines in 2 files covered. (100.0%)

17392 of 18372 relevant lines covered (94.67%)

196.96 hits per line