IgniteUI / igniteui-angular / 36538706952

92%

push

github

fix(combo): Fix remote combo binding pages two rows high (#17675)

The virtual scroll reports its rendered range, over-scan included, but
the combo's virtualizationState and dataPreLoad promise the first
visible row, as igxFor did. A page fetched for that row bound two rows
too high, and reopening the combo did not correct it. The combo now
disables over-scan, so the reported start is the first visible row.

Without over-scan, a second bug became visible: after the list shrank,
the virtual scroll rendered from the old scroll offset until the
browser's scroll event arrived a frame later. The engine now clamps the
offset to the reachable range.

Closes #17670

15616 of 17787 branches covered (87.79%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

31391 of 33403 relevant lines covered (93.98%)

38386.83 hits per line