safe-global / safe-client-gateway / 36530955628

89%

push

github

feat(ci): move production onto the event-driven pipeline and delete ci.yml (#3493)

* feat(ci): move production onto the event-driven pipeline and delete ci.yml

Last of the four PRs splitting ci.yml into reusables plus callers. `production.yml` takes over the release event and `ci.yml` goes, leaving no trace of the monolith.

**Do not merge this before the production ArgoCD cutover.** The build half is safe — it publishes exactly the four tags ci.yml published, verified by simulating the tag composition: vX.Y.Z and latest on both GHCR and Docker Hub. The deploy half is not: it bumps values-production.yaml in the infra repo and then polls production until it reports the new tag, and production still renders from legacy-safe-argocd-mgmt. Until that changes, every release would build correctly and then sit in a ten-minute timeout before failing loudly. Land this with the cutover window, not ahead of it.

Two corrections to what this file inherited from safe-config-service.

**`released` instead of `published`.** `ci.yml` and `linear-release.yml` both use `released`, and the difference is not only that `published` also covers pre-releases. `published` does not fire again when a pre-release is promoted to a full release, so the soak-then-promote flow would tag a release and silently never deploy it — the `!prerelease` guard skips the build on the first event and nothing fires on the second. `released` covers the promotion and matches the rest of the repo. One line to flip if the team decides otherwise; the decision is recorded in WA-3421.

**`/about`, not `/v1/about`.** AboutController declares no version and app.provider.ts enables URI versioning with no defaultVersion, so the route is registered unversioned and /v1/about returns 404. With the inherited value the health gate would have timed out on every production deploy. Production also sits behind CloudFront, which rejects any User-Agent that does not look like a browser's — `_deploy.yml` already send... (continued)

4492 of 5283 branches covered (85.03%)

Branch coverage included in aggregate %.

11482 of 12598 relevant lines covered (91.14%)

546.17 hits per line