NVIDIA / nodewright / 36491515906
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.479% (+0.08%) from 82.4%
36491515906

push

github

web-flow 
test(agent): gate the simple and reap_old_logs operator-agent assertions (#683)

Chainsaw runs script.content as `sh -c` with no `set -e`, so only the last
command's exit status reaches the test and every check_node.sh call above it
is decorative. Three blocks in the pre-existing scenarios had this:

- simple/: five assertions -- log content twice, the START flag, the step
  flag path and the history file -- of which only the final `ls .../history`
  gated. The log-content and flag-path checks, the ones that would notice a
  format drift between the two agents, could not fail the test.
- reap_old_logs/: the survivor block's `^5$` count did not gate; only the
  `newest` content check after it did. The seed block's `^7$` count already
  gated, since the check_node.sh call was that block's only command; `set -e`
  goes in there too so a second check added later is gated from the start.

interrupt/, dont_write_logs/ and the scenarios added in #605 and #673 already
set it. This is the remainder. The cleanup blocks (`rm -rf ... || true`) are
intentionally non-gating and are unchanged. reap_old_logs/'s pre-run
`nodewright reset` gains the `2>/dev/null || true` guard simple/ has, so the
two scenarios treat an absent CR the same way.

check_node.sh also stops counting a positive match when the command itself
exited non-zero: `cat a.log b.log` prints a.log and fails on an unreadable
b.log, and that output must not pass a check. Inverted checks assert absence,
where a command with nothing to list exits non-zero by design, so they keep
matching on output alone. The failure diagnostic now prints the exit status.

This suite is the parity contract the Go cutover (#222) leans on; until now
"the suite passes" meant one of five simple/ assertions passed.

Closes #680

Signed-off-by: Riley Rice <rrice@nvidia.com>

9368 of 11358 relevant lines covered (82.48%)

7.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
80.04
0.42% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 36491515906.1 59
82.48
GitHub Action Run
Source Files on build 36491515906