kubeflow / trainer / 36486345418

72%

push

github

fix(framework): prevent potential nil pointer dereference on NumProcPerNode in MPI plugin (#4049)

In MPI plugin EnforceMLPolicy, NumProcPerNode was directly dereferenced with * without verifying if the pointer was non-nil. When NumProcPerNode was nil in the runtime policy, this could cause a nil pointer dereference panic.

This commit safely dereferences NumProcPerNode using ptr.Deref with a fallback default value of 1.

Closes #4048

Signed-off-by: Ayush Raj <light1ooo7710@gmail.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

2762 of 3970 relevant lines covered (69.57%)

0.81 hits per line