solidjs / solid / 36477505650

74%

main: 89%

push

github

fix(signals): unchanged store key read under a held fold does not hold the reader (#3688) (#3693)

* fix(signals): an unchanged store key read does not hold the reader with an open action (#3688)

The container-level hold gate (pendingBackingVisible → holdVisible) entered
a deriving pass into the fold's transaction for ANY key of a held container.
A memo reading store.stable — a key the action never wrote — beside an
independent signal was held until the action settled, and the signal's
isPending went true (A29 says a read served a STAGED value enters; an
untouched key's value is not staged).

The gate now takes the key from the get/has/getOwnPropertyDescriptor traps
and consults the fold's trap-recorded written keys (wk, deletes included):
a key the fold never touched reads the same from either backing and is
served committed with no entry and no stale replay. ownKeys//deep()
stay container-wide; optimistic families, chained backings, wk null and
WK_ALL keep the whole-container hold.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(size): Rolldown ledger for store key-precision at the held-fold gate (#3688)

Re-measured under the Rolldown harness against `next` @ b10c8249d after
the rebase (the esbuild-era ledger edits were dropped in the rebase):
+ createStore 16,707 -> 16,708 B (+1 B; +118 B minified), hydrating +
every store 30,584 -> 30,622 B (+38 B), base page 44,929 -> 44,919 B
(-10 B), live page 49,066 -> 49,057 B (-9 B); every cap unchanged, no
Size-Exception. Regenerates docs/RULES-INDEX.md (A29 gains the #3688
test citation).

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

625 of 912 branches covered (68.53%)

Branch coverage included in aggregate %.

920 of 1181 relevant lines covered (77.9%)

27.41 hits per line