aio-libs / multidict / 36470950931

87%

push

github

Drop ASSERT_CONSISTENT()'s update flag (#1629)

<!-- Thank you for your contribution! -->

## What do these changes do?

`ASSERT_CONSISTENT(md, update)` took a flag that relaxed the debug-only
consistency check for the half-deleted entries (`key == NULL`, identity
kept) that `update()` used to leave in the table mid-batch. #1628
removed half-deletion and made the check strict on every call, leaving
the flag ignored; this drops it from the macro,
`_md_check_consistency()` and every call site.

## Are there changes in behavior for the user?

No. The macro compiles to nothing in release builds.

## Is it a substantial burden for the maintainers to support this?

No, it removes a parameter.

## Related issue number

Follows #1628.

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change; the
debug suites exercise every call site)
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`tools/codegen_diff.py --ref upstream/master` (9684a61, #1628 merged): 0
of 256 functions differ on 3.14.7, 0 of 265 on 3.14.7t (release flags).
Full suite with `MULTIDICT_DEBUG_BUILD=1`, where every
`ASSERT_CONSISTENT()` runs: GIL 3.14.7 3028 passed, FT 3.14.7t 3016
passed.

Lint: pre-commit clean.
</details>

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

790 of 1580 branches covered (50.0%)

Branch coverage included in aggregate %.

8779 of 9419 relevant lines covered (93.21%)

1.86 hits per line