solidjs / solid / 36457522229

76%

main: 89%

push

github

fix(compilers): textarea value fold must not reserve a hydration id (#3691) (#3696)

* fix(compilers): textarea value fold must not reserve a hydration id (#3691)

The SSR textarea value/defaultValue fold turns the attribute into a
dynamic text child, and that child took the `_$scope` hydration-id
reservation a dynamic hole gets. The client writes the value as a plain
property effect that never allocates an id, so every component after the
textarea hydrated one id off and its updates targeted detached DOM.

Treat the fold like the innerHTML/textContent redirects (#3015): opaque
content, no reservation. Babel flags the folded container with
_childProperty; the native compiler skips the reservation for a
children_replacement. Shared fixture + parity-harness scenario added.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(babel-plugin): use the local @babel/types namespace in the textarea fold flag

The fold's _childProperty cast referenced `babelTypes`, which utils.ts does
not import (it aliases @babel/types as `t`). Rollup's transpile let it
through; the typecheck step did not.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

625 of 914 branches covered (68.38%)

Branch coverage included in aggregate %.

922 of 1183 relevant lines covered (77.94%)

27.25 hits per line