wegamekinglc / Derivatives-Algorithms-Lib / 36449405077

92%

push

github

fix: honor element types and rvalue moves in containers (#458)

* Fix element-type access in SquareMatrix_ and Cube_

SquareMatrix_<E_>::operator() and Cube_<E_>::operator() / SliceBegin /
SliceEnd returned double& / double*, so instantiating either template
with a non-double element type failed to compile. Return E_& / E_*
instead so the containers honor their element type parameter. Both were
latent bugs: every current use site is double-only.

* Move rvalue arguments in Vector_::emplace_back

The variadic forward to std::vector::emplace_back dropped the value
category, so rvalue arguments were copied: move-only element types
failed to compile and movable types paid an extra copy. Forward with
std::forward to preserve the value category.

4 of 4 new or added lines in 2 files covered. (100.0%)

18113 of 19618 relevant lines covered (92.33%)

3174583.66 hits per line