aio-libs / yarl / 36439868226

98%

Build Type

push

github

Committed by web-flow

Commit Message

Add per-URL mode selecting RFC 3986 or WHATWG (#1931)

* Add per-URL compat mode selecting RFC 3986 or WHATWG

URL() and URL.build() accept compat="rfc" or compat="whatwg" (the
default), or a member of the new Compatibility enum, and URL.compat
reports it. Derived URLs keep the mode of the URL they come from; join()
uses the base URL's mode. The mode is excluded from equality and hashing
and survives pickling. Both modes behave the same for now; later changes
can make parsing depend on the mode.

* Default compat to None to keep the URL() hot path cheap

Comparing with a module-level enum member costs a global lookup on every
cached URL(str) call; None is a constant. Both URL() and URL.build() treat
None as WHATWG.

* Rename compat to mode and Compatibility to Mode

The argument and property are now URL(..., mode=...) and URL.mode, and
the enum is yarl.Mode. None stays an undocumented internal default for
WHATWG; URL() also matches "whatwg" with == before normalizing, so an
explicit WHATWG argument skips the lookup. Drop the no-op sys.intern.

* Raise ValueError for an unhashable mode

The mode lookup hashes its argument, so a value such as a list raised
TypeError instead of the documented ValueError.

Coverage Stats

93 of 186 branches covered (50.0%)

Branch coverage included in aggregate %.

241 of 246 new or added lines in 4 files covered. (97.97%)

1 existing line in 1 file now uncovered.

8072 of 8182 relevant lines covered (98.66%)

0.99 hits per line