FIWARE / VCVerifier / 36436946589

73%

main: 73%

Build Type

Pull #129

github

Committed by wistefan

Commit Message

Fix the staticcheck findings

golangci-lint reported six issues; its max-same-issues default of 3 hid
nine more of the same kind, so this fixes fifteen sites.

QF1012: build the \uhhhh escape for a control character from its two hex
digits instead of WriteString(fmt.Sprintf(...)). Every character that
needs the escape is below U+0020, so the two high digits are constant.

QF1008 (12 sites): drop the embedded PublicKey from privKey.PublicKey.X
and .Y.

SA1019 (2 sites): elliptic.Marshal and elliptic.Curve.IsOnCurve are
deprecated. crypto/ecdh's PublicKey.Bytes() is the same uncompressed
SEC 1 encoding, and ecdsa.PublicKey.ECDH() performs the same on-curve
check - NewPublicKey rejects a point that is not on the curve - so the
test still asserts what it asserted before.

Verified with staticcheck -checks=all: no QF or SA findings remain. The
ST (naming) findings it also reports are pre-existing across the
repository and are not enabled in the CI configuration.

Pull Request Pull Request #129: Ticket 64/work

Coverage Stats

471 of 551 new or added lines in 6 files covered. (85.48%)

51 existing lines in 3 files now uncovered.

8688 of 12007 relevant lines covered (72.36%)

0.83 hits per line