cybertec-postgresql / vip-manager / 36418207370

91%

push

github

[!] poll the etcd leader key instead of watching it (#436)

The watch kept producing bugs: cancelled watches (#228), events lost while
the watch was down (#394), a failed re-sync leaving a healthy watch silent
(#431), and the startup read racing the watch. While etcd is unreachable the
client retries the watch without closing its channel, so the checker sent
nothing and a node kept its VIP for the whole outage (#435).

The etcd checker now reads the key once per interval, like the Consul and
Patroni checkers. A failed read sends false, and the next successful read
sends the current value. The value is logged only when it changes, and read
failures stay throttled. interval applies to etcd again, so the README note
saying otherwise is gone and the e2e test uses the default interval.

12 of 12 new or added lines in 1 file covered. (100.0%)

860 of 940 relevant lines covered (91.49%)

1.35 hits per line