eclipse-aascw / aas-core-codegen / 36399939998

90%

Build Type

push

github

Committed by web-flow

Commit Message

Transpile general if statements (#788)

We transpile the chains of ``if``, ``elif`` and ``else`` in the bodies
of transpilable functions which can not be mapped to a switch, *e.g.*:

    if number < 0 and len(text) > 0:
        return False
    elif number == 13:
        return False

The parse tree gets an ``If`` statement with a sequence of branches and
an optional default. The detection of switches stays greedy: a chain
whose first test compares a subject against constants is still
a switch, and a non-matching ``elif`` becomes an if-statement in its
default.

The type inference refuses the conditions which are not booleans, as
the targets do not share Python's truthiness, and treats the branches
as block scopes, analogous to the switches. We deliberately do not
narrow the types by the conditions yet, *e.g.*, ``x`` stays optional in
the body of ``if x is not None:``.

All the targets transpile to native chains of ``if`` and ``else if``.
Java and C++ share the writing of the chains with their fallback for
the switches on ``long`` and strings, respectively.

Along the way, we fix the line break of the long assignments in Go,
which ended with a stray parenthesis, ``x :=\n\tvalue)``.

The new common meta-model ``if_statements`` covers the variants,
including a ``continue`` in a branch nested in a for-loop.

Coverage Stats

349 of 402 new or added lines in 13 files covered. (86.82%)

2 existing lines in 2 files now uncovered.

41589 of 46979 relevant lines covered (88.53%)

2.66 hits per line