aio-libs / multidict / 36387352231

87%

push

github

Drop a hash table through one release helper (#1618)

<!-- Thank you for your contribution! -->

## What do these changes do?

`_md_rebuild()` and `md_clear()` each had their own `#ifdef` for
dropping a table they had just unpublished: retire it on free-threaded
builds, free it on GIL ones. `md_clear()`'s GIL arm also released the
entries with its own loop, a copy of the one `_md_free_retired()` ran
for retired tables. `_md_release_keys()` now makes the build choice for
both callers, and the one loop, `_htkeys_dispose()` (renamed from
`_md_free_retired()`), serves both the GIL release and the free-threaded
drain.

`_htkeys_dispose()` is `NOINLINE`: inlined, it grew every `md_clear()`
caller by about 400 bytes and cost `ctor_empty` 2% on GIL.

C extension only; no behaviour change.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes a duplicated loop and two `#ifdef` blocks.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change;
covered by the existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Opus 5.5 (Claude Code); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Callgrind (`benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, CPython 3.14.7 and 3.14.7t) against master 512f00a,
MultiDict and CIMultiDict:

- GIL: every row within 0.33% (`ctor_empty` 615 -> 617 Ir).
- FT: every row within 0.36% (`copy_small` 2749 -> 2759 Ir).

Also tried and dropped: collapsing `htkeys_alloc_sized()` and
`_htkeys_alloc_raw()` into one `htkeys_allo... (continued)

779 of 1558 branches covered (50.0%)

Branch coverage included in aggregate %.

8471 of 9041 relevant lines covered (93.7%)

1.87 hits per line