jhillyerd / enmime / 36367083670

87%

push

github

fix: keep encoded-word params with embedded quotes intact when parsing media types (#417)

RFC 2047 decoding in fixMangledMediaType was applied to whole key=value
chunks, including inside quoted-strings. When the encoded payload decoded
to a value containing a double quote, the raw quote was injected into the
quoted-string, breaking its structure. fixUnescapedQuotes then treated the
last quote in the header as the value terminator, folding all remaining
parameters into the filename value.

Skip the early decode when it would add quote characters to a chunk that
already contains quotes; the encoded word is decoded later, per-parameter,
by coding.DecodeExtHeader in setupContentHeaders.

Fixes https://github.com/jhillyerd/enmime/issues/384

11 of 11 new or added lines in 1 file covered. (100.0%)

3584 of 4101 relevant lines covered (87.39%)

4170.89 hits per line