5.0.0.2273
95%

Ran 27 Sep 2026 11:14PM UTC

Jobs 1

Files 200

Run time 1min

Badge

Embed ▾

Committed 27 Sep 2026 10:57PM UTC coverage: 94.918% (-0.003%) from 94.921%

Build # 5.0.0.2273

Build Type

push

coveralls.net

Committed by

jstedfast

Commit Message

Removed no-op finalizers

Every one of these finalizers simply called Dispose (false), but in all
7 classes the Dispose (bool) implementation is guarded by `if (disposing
...)`, making the finalizer a complete no-op. The only effect was to add
each instance to the GC's finalization queue, which is pure overhead for
types like MimeEntity, MimeMessage and MimeContent that get allocated on
a per-message basis.

None of these classes directly own unmanaged resources (they hold Streams,
MimeEntities and a DbConnection - all managed types with their own
finalization if needed), so per CA1063 guidance they should not have a
finalizer at all.

This also fixes the CodeQL cs/virtual-call-in-constructor-or-destructor
alerts for X509CertificateDatabase and MimeMessage.

Dispose (), Dispose (bool) and the GC.SuppressFinalize () calls are all
left intact so that subclasses needing a finalizer can still add one.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

33431 of 35221 relevant lines covered (94.92%)

0.95 hits per line

Coverage Regressions

Lines	Coverage	∆	File
50	94.55	-0.02%	D/a/MimeKit/MimeKit/MimeKit/MimeMessage.cs
21	92.88	-0.07%	D/a/MimeKit/MimeKit/MimeKit/Tnef/TnefReader.cs
18	95.96	-0.03%	D/a/MimeKit/MimeKit/MimeKit/MimeEntity.cs
16	95.53	-0.03%	D/a/MimeKit/MimeKit/MimeKit.Cryptography/X509CertificateDatabase.cs
8	92.79	-0.19%	D/a/MimeKit/MimeKit/MimeKit/MimeContent.cs
6	95.77	-0.09%	D/a/MimeKit/MimeKit/MimeKit/MimeIterator.cs
1	99.58	-0.01%	D/a/MimeKit/MimeKit/MimeKit/Text/HtmlWriter.cs

Jobs

ID	Job ID	Ran	Files	Coverage
1	5.0.0.2273.1	27 Sep 2026 11:14PM UTC	200	94.92

jstedfast / MimeKit / 5.0.0.2273
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 5.0.0.2273

jstedfast / MimeKit / 5.0.0.2273 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 5.0.0.2273

jstedfast / MimeKit / 5.0.0.2273
95%

README BADGES
x