eclipse-aascw / aas-core-codegen / 36351585699

90%

Build Type

push

github

Committed by web-flow

Commit Message

Handle the interplay of integers and lengths (#785)

We represent the integers of the meta-model as 64-bit, while the lengths
are narrower in some targets (``int`` in C#, Java and Go, ``size_t`` in
C++). Mixing the two did not compile, *e.g.*, the index ``xs[i]`` with
``i: int`` in C# and Java, or silently wrapped around in C++.

We now widen by default, and narrow only where the targets require an
``int``. The type inference types ``len(xs) - 1`` as a length, but
``len(xs) - k`` with ``k: int`` as an integer, and allows assigning
a length to an integer. The targets widen the lengths accordingly
(``int64(len(xs))``, ``static_cast<int64_t>(xs.size())``,
``(long) xs.size()``), and narrow the integer indices with a check
(``xs[checked((int)i)]``, ``xs.get(Math.toIntExact(i))``).

We also fix the following: C++ declared all transpilable verification
functions as returning ``bool``, the ranges over integers in ``any`` and
``all`` did not compile in C++, Go, C# and Java, ``Enumerable.Range``
threw on an empty range in C#, and the generated Python tests could not
trace a sequence of primitives.

The new common meta-model ``int_length_interplay`` covers these cases.

Coverage Stats

123 of 136 new or added lines in 6 files covered. (90.44%)

8 existing lines in 2 files now uncovered.

41209 of 46561 relevant lines covered (88.51%)

2.66 hits per line