ConnectionMaster / json / 36346474524

98%

push

github

Fix MSVC: avoid reserving by faked size in MessagePack size tests (#5604)

The "Size above uint32" tests for arrays and objects fake a container
size of 2^32 and expect to_msgpack() to throw out_of_range.412. But
to_msgpack(j) first reserves binary_reserve_hint(j) bytes, which is
size + 1 for arrays and 2 * size + 1 for objects, i.e. 4 or 8 GiB.
Linux and macOS overcommit, so the reservation succeeds; on Windows it
throws std::bad_alloc before the size check is reached (seen with
msvc-vs2026 Debug x64 on the object test).

Write into a caller-owned vector instead, so nothing is reserved.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

3068 of 3188 branches covered (96.24%)

Branch coverage included in aggregate %.

8320 of 8415 relevant lines covered (98.87%)

13190769.19 hits per line