coderaiser / putout-editor / 36337843697

100%

push

github

feature: plugin-putout-editor: remove-undefined-token, the var() that renders nothing

The other two css rules say a value belongs in tokens.css. Nothing said you thought you put
it there and did not, so codemirror.css has carried

  [data-theme='dark'] .cm-selectionBackground { background: var(--color-selection-bg) !important; }

since before tokens.css existed, next to a --color-selection-focused that did exist. The
browser drops a declaration whose custom property is undefined, so that selector looked
styled and was not. It is found on the first run, which is the argument for the rule: a
filesystem rule sees the tree, a single-file rule never would have.

A scan, not matchFiles - the check is "this name is defined over there", and only the tree
answers that. Report-only, because a missing token needs a value and a value is a human
call; the fix is returning the file unchanged, and the test asserts the css is still in the
output byte for byte.

The token it found is now in tokens.css, beside the --color-selection-focused it was
renamed from, in the light root and both dark blocks. Defined rather than renamed at the use
site, because the pair is the architecture: unfocused and focused selection, two names, two
values. Renaming the usage would have left the scale with a hole in it.

Also: the markdown disables move to the root, the way the putout repo does it. The plugin
README documents remove-duplicated-receiver with the anti-pattern in a js fence, and a js
fence is linted as real JavaScript - so the rules have to be off for *.md, and the answer to
that is the config, not a hand-written example that satisfies the linter. That is what the
putout repo does with its own "*.md" block.

39 tests, 100% on all four metrics, putout clean, tsc clean, redlint 100% on all three css
rules.

1081 of 1081 branches covered (100.0%)

Branch coverage included in aggregate %.

6663 of 6663 relevant lines covered (100.0%)

61.54 hits per line