• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

chideat / valkey-operator / 36318404581
36%

Build:
DEFAULT BRANCH: main
Ran 27 Sep 2026 12:19PM UTC
Jobs 1
Files 151
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

27 Sep 2026 11:54AM UTC coverage: 35.432% (+8.8%) from 26.646%
36318404581

push

github

chideat
fix: ask for one node port per pod in access.ports (#141)

Admission checks that access.ports lists as many node ports as the
instance has pods, and CalculateNodeCount counted them as if
replicasOfShard were the replicas besides each master: shards *
(replicasOfShard + 1) for cluster, shards + replicasOfShard for failover
and 1 for replica. The operator runs replicasOfShard pods in each shard:
the cluster StatefulSets and the Failover of the failover and replica
architectures get replicasOfShard replicas, and the actors take one
configured port for each pod. So admission refused every list that fit
the instance, and accepted only lists with more ports than pods.

CalculateNodeCount now returns shards * replicasOfShard for cluster and
replicasOfShard for failover and replica, and its parameters take the
names of the fields the webhook passes. The sentinel count was already
right.

No object can depend on the old count: until #140, no Valkey resource
could set access.ports at all.

The Valkey and Cluster APIs described replicasOfShard in the same terms.
The description, the CRDs generated from it, the API docs and two example
comments now say it is the number of pods in each shard, the primary
included.

(cherry picked from commit 67a7ff690)

4 of 4 new or added lines in 1 file covered. (100.0%)

453 existing lines in 23 files now uncovered.

7766 of 21918 relevant lines covered (35.43%)

0.4 hits per line

Coverage Regressions

Lines Coverage ∆ File
131
0.0
0.0% api/v1alpha1/zz_generated.deepcopy.go
74
31.45
30.84% internal/ops/cluster/actor/actor_ensure_resource.go
72
38.61
31.6% internal/ops/failover/actor/actor_ensure_resource.go
53
38.83
32.13% internal/ops/sentinel/actor/actor_ensure_resource.go
24
0.0
0.0% api/core/zz_generated.deepcopy.go
16
0.0
0.0% api/rds/v1alpha1/zz_generated.deepcopy.go
12
86.25
69.75% internal/builder/clusterbuilder/statefulset.go
11
93.68
-4.27% internal/builder/failoverbuilder/service.go
11
97.19
-0.44% internal/builder/sentinelbuilder/statefulset.go
8
94.16
-5.84% internal/builder/clusterbuilder/service.go
7
96.23
1.57% internal/webhook/rds/v1alpha1/valkey_webhook.go
5
0.0
0.0% internal/controller/rds/valkey/cluster.go
4
0.0
0.0% internal/controller/rds/valkey/failover.go
3
0.0
0.0% api/rds/v1alpha1/valkey_types.go
3
0.0
0.0% api/v1alpha1/cluster_types.go
3
0.0
0.0% api/v1alpha1/failover_types.go
3
0.0
0.0% api/v1alpha1/sentinel_types.go
3
95.6
-0.5% internal/builder/sentinelbuilder/service.go
2
74.19
-1.61% cmd/helper/sync/file.go
2
92.86
-7.14% internal/builder/clusterbuilder/poddisruptionbudget.go
2
92.86
92.86% internal/builder/failoverbuilder/poddisruptionbudget.go
2
92.86
92.86% internal/builder/sentinelbuilder/poddisruptionbudget.go
2
97.65
0.59% internal/webhook/rds/v1alpha1/validation/validation.go
Jobs
ID Job ID Ran Files Coverage
1 36318404581.1 27 Sep 2026 12:19PM UTC 151
35.43
GitHub Action Run
Source Files on build 36318404581
  • Tree
  • List 151
  • Changed 26
  • Source Changed 0
  • Coverage Changed 26
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 43388042 on github
  • Prev Build on main (#36309739688)
  • Next Build on main (#36319692249)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc