|
Ran
|
Jobs
1
|
Files
151
|
Run time
1min
|
Badge
README BADGES
|
push
github
fix: ask for one node port per pod in access.ports (#141) Admission checks that access.ports lists as many node ports as the instance has pods, and CalculateNodeCount counted them as if replicasOfShard were the replicas besides each master: shards * (replicasOfShard + 1) for cluster, shards + replicasOfShard for failover and 1 for replica. The operator runs replicasOfShard pods in each shard: the cluster StatefulSets and the Failover of the failover and replica architectures get replicasOfShard replicas, and the actors take one configured port for each pod. So admission refused every list that fit the instance, and accepted only lists with more ports than pods. CalculateNodeCount now returns shards * replicasOfShard for cluster and replicasOfShard for failover and replica, and its parameters take the names of the fields the webhook passes. The sentinel count was already right. No object can depend on the old count: until #140, no Valkey resource could set access.ports at all. The Valkey and Cluster APIs described replicasOfShard in the same terms. The description, the CRDs generated from it, the API docs and two example comments now say it is the number of pods in each shard, the primary included. (cherry picked from commit 67a7ff690)
4 of 4 new or added lines in 1 file covered. (100.0%)
453 existing lines in 23 files now uncovered.7766 of 21918 relevant lines covered (35.43%)
0.4 hits per line
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 36318404581.1 | 151 |
35.43
|
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|