google / alioth / 36300265981

38%

push

github

fix(virtio): ignore changes to enabled queues

The driver could write the ring addresses of a queue and disable it
through queue_enable at any time, even while the device was running.
Only queue_size was locked once the queue was enabled.

The virtio spec requires the driver to set up a queue before enabling
it, and to not write 0 to queue_enable unless VIRTIO_F_RING_RESET is
negotiated, which Alioth does not offer. Ignore such writes, like
queue_size already does, so that the worker never sees the ring
addresses of a running queue change. Queues are still disabled by a
device reset.

Assisted-by: Antigravity:Claude-Opus-5
Signed-off-by: Changyuan Lyu <changyuanl@google.com>

779 of 1594 branches covered (48.87%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 1 file covered. (100.0%)

5680 of 15496 relevant lines covered (36.65%)

920.75 hits per line