bacluc-agent / ecamp3 / 36292474981

37%

devel: 37%

Build Type

Pull #43

github

Committed by Agent Runner

Commit Message

revert(api): restore the unmodified checklist validation expectation

Reverts the edits to api/tests/Api/Checklists/DeleteChecklistTest.php made by
5822fcec7 and
f90fd7472, returning the file to its devel
content byte for byte. No other file of this branch is touched.

The change was scope creep that the api-platform v5 bump does not require.
Commit 5822fcec7 moved the expected index from checklistItems[0] to
checklistItems[2]; f90fd7472 then deleted the exact-match

  'detail' => 'checklistItems[0].checklistNodes: It's not possible to delete
   a checklist item as long as checklist nodes are referencing it.'

out of assertJsonContains() and replaced it with
assertMatchesRegularExpression('/^checklistItems\[\d+\]\.checklistNodes: ...$/').
That is a weakened expectation, which AGENTS.md forbids without asking a human
first. This commit removes the need for that ask instead of making it: nothing
is removed or weakened, a file is restored, so no human decision is required.

The original expectation passes under api-platform v5. The dispatched run
https://github.com/bacluc-agent/ecamp3/actions/runs/36254307315 at head
0e1716e18 with v5 installed ends "Tests: 2792, Assertions: 6430, Failures: 2"
and its only two failures are the MaterialItem PATCH denormalization cases, so
DeleteChecklistTest already passed there with devel's checklistItems[0].

The ordering sensitivity this branch tried to absorb is a pre-existing flake,
not a consequence of the v5 bump: api/src/Entity/Checklist.php:112 declares no
#[ORM\OrderBy] on checklistItems, so the position of the referencing item
depends on database return order, and the referenced item is
checklistItem1_1_1 (api/fixtures/checklistNodes.yml:9-10). The flake stays
unfixed here; fixing it belongs in an issue of its own and must not be folded
into a dependency bump.

Pull Request Pull Request #43: fix(api): complete the api-platform v5.0.0 bump and regenerate the lock

Coverage Stats

888 of 4711 branches covered (18.85%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

4978 of 11052 relevant lines covered (45.04%)

63.66 hits per line