solidjs / solid / 36286271124

74%

main: 89%

push

github

test(signals): optimistic list-mutation oracle matrix

Two user-reported optimistic bugs in one week were plain list mutations
the array / For suites cover exhaustively but the optimistic path had
never seen: #3662 (two overlapping optimistic moves under a keyed For
with a nested Show disposed the lane's inner effect; fixed in #3669) and
#3672 (a chained optimistic store dropped a write back to the pre-action
value, a re-add of a deleted key, a pop of an appended row; fixed in
#3674). This matrix makes every optimistic list bug one more row.

Oracle pattern (visibility-oracle-store.states.ts): a plain createStore
rendered by the same reader is the oracle; every optimistic context must
show the oracle's frame for the same cumulative mutation list at each
checkpoint on the effect channel and the untracked channel, with only
the optimistic and final frames between apply and settle.

Matrix: 18 mutations over a 6-row keyed list (no-op, swap, reverse,
rotate, move head->tail / tail->head / middle, insert head/middle/tail,
delete head/middle/tail, clear, replace-all disjoint / same ids
reordered, text update in place, delete-then-re-add, append-then-pop)
x contexts (1 plain oracle self-check; 2 one action confirmed with the
same truth and with a different truth; 3 two overlapping actions
resolved in both orders, 4 pairs; 4 chained over a base committing
outside the action, while pending and after settle, then the inverse;
5 mutation + inverse in one action and across two) x truth sources
(derived from a signal; chained over a createStore) x readers (mapArray
keyed by id, mapArray by index, repeat, createMemo over the joined
rows), each list reader with an onCleanup and a nested memo per row,
published through the nested-insert effect shape of #3662. 900 rows:
691 pass, 209 pinned it.fails.

Invariants per checkpoint: frame equality on both channels; no row
displayed after its cleanup ran; after settle no republish, the
untracked read serves the truth, an am... (continued)

625 of 914 branches covered (68.38%)

Branch coverage included in aggregate %.

922 of 1183 relevant lines covered (77.94%)

27.24 hits per line