jhillyerd / enmime / 36268362935

87%

push

github

Read Content-Disposition from parts without a Content-Type (#415)

setupHeaders returned early when a child part had no Content-Type
header, before setupContentHeaders and the Content-ID lookup ran. A
part carrying `Content-Disposition: attachment; filename="notes.txt"`
but no Content-Type therefore got an empty Disposition, FileName and
ContentID, and was listed in OtherParts instead of Attachments (or
Inlines for an inline disposition). The same happened for a part with
an empty Content-Type header value.

Content-Disposition and Content-ID do not depend on the Content-Type,
so read them before the early return. ContentType stays empty as
before, with the same Missing Content-Type warnings.

Fixes #414

Co-authored-by: Aditya <205600203+Rohilalala@users.noreply.github.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

3418 of 3930 relevant lines covered (86.97%)

4331.46 hits per line