solidjs / solid / 36229998558

74%

main: 89%

push

github

fix(signals): own undeclared optimistic store flights by the firewall's transaction (#3663)

* fix(signals): own undeclared optimistic store flights by the firewall's transaction

An optimistic store that derives synchronously from an async source is
pending without a declared flight, so every transaction holding overrides
on it parked until it settled. When the refetch ran under another
transaction (a router action revalidates after an await), its landing never
re-entered the parked action transaction, which kept mapArray index writes
and the overlay held forever (solidjs/solid-router#619, #620).

* refactor(signals): let liveTransition take null and trim the #619 test header

625 of 914 branches covered (68.38%)

Branch coverage included in aggregate %.

922 of 1183 relevant lines covered (77.94%)

27.19 hits per line