twbs / bootstrap / 36214033423

94%

main: 96%

push

github

Relocate overflowing nav menus as overflow submenus (#42873)

* Relocate overflowing nav menus as overflow submenus

A nav item that hosts a menu used to collapse into a plain cloned link.
The menu became unreachable once the nav item overflowed, so a nested
menu was lost at narrow widths.

Move the original `.menu` into a `.submenu` of the overflow menu instead
of cloning it. One live menu keeps its ids, its nested submenus, and its
node state. Only the trigger is cloned, with the menu data attributes
stripped and `aria-haspopup` added. Restore moves the menu back to its
nav item and disposes the menu instances that were created.

* Type a relocated menu parent as ParentNode

`tsc` rejected `parent.append(menu)`, because `Node` does not declare
`append`. Store the parent as `ParentNode`, which does, and which is what
`Node.parentNode` already returns.

* Raise the JS bundlewatch budgets

The submenu relocation adds about 0.4KB gzipped to the minified builds,
and both budgets had under 0.1KB of headroom. Move
`bootstrap.min.js` to 34.0KB and `bootstrap.bundle.min.js` to 56.0KB.

* Handle menu state during nav overflow relocation

An open nav menu kept stale classes when its item moved into overflow.
Menus moved to another container were also missed, and cloned anchor
triggers lost keyboard focus.

Cache each hosted menu before it can move, reset open state during
relocation, and keep anchor triggers focusable. Add regression coverage
for relocation, nested interaction, container menus, and menu rebuilds.
Raise the bundled size budget to fit the added handling.

* Raise the unminified bundlewatch budget

The bundled build is 73.13KB after the nav overflow changes, which is
above the 73KB limit. Raise the limit to 73.25KB.

* Fully round nav pills

The radius token leaves visible corners on taller pill navigation. Use a
component-specific 3rem radius for the pill container and links.

* Fix nav overflow startup and clipped menus

Resizable examples clip... (continued)

1820 of 2048 branches covered (88.87%)

Branch coverage included in aggregate %.

69 of 71 new or added lines in 1 file covered. (97.18%)

3715 of 3856 relevant lines covered (96.34%)

129.95 hits per line