polserver / polserver / 36192247533
82%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 856
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.943% (+0.02%) from 81.927%
36192247533

push

github

web-flow 
Take the war mode throttle and slow swings out of the client tests (#983)

* Stop the test client sleeping on its own shutdown and polling for state

None of these changes the package time. Each removes a wait or a cost
on its own.

- run() slept a second before closing the control connection. A
  half-close puts a FIN behind the last reply instead.
- waitFor() blocks on a signal the client raises after each burst,
  instead of a 10ms poll.
- getEquipByLayer() had no timeout.
- dcstring() and ducstringz() built strings a byte at a time.
- Speech is formatted for the log only when the log will print it.
- 0x2D, party member vitals, is decoded instead of logged as unhandled.

* Take the war mode throttle out of the client tests

A war mode change within WarModeDelay is answered with a movement packet
and ignored, so set_warmode() retried for up to a second per change.
The test shard sets WarModeDelay=0.

test_client_trade_open: 18.2s -> 40ms. Client package: 70.9s -> 63.8s.

* Let the combat tests swing ten times as fast

The combat tests mostly wait on the swing timer, about two seconds per
swing at the default rate. schedule_attack() divides the delay by
1 + swing_speed_increase/100, so the tests set swing_speed_increase_mod
for a 190ms swing.

The "no further swing" windows shrink from 2000ms to 600ms, which covers
three swing timers instead of one.

test_attack: 13.9s -> 3.4s. test_attack_item: 16.3s -> 3.4s.

60265 of 73545 relevant lines covered (81.94%)

601933.29 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
88.69
-0.9% pol-core/pol/module/npcmod.cpp
2
89.23
-0.44% pol-core/pol/miscmsg.cpp
Jobs
ID Job ID Ran Files Coverage
1 36192247533.1 856
81.94
GitHub Action Run
Source Files on build 36192247533