aio-libs / multidict / 36182162442

87%

push

github

Add md_shell_new() for the repeated multidict shell setup (#1592)

<!-- Thank you for your contribution! -->

## What do these changes do?

Five constructors (the `MultiDict`/`CIMultiDict` vectorcall, `tp_new`,
`copy()`, and the C API `MultiDict_New`/`CIMultiDict_New`) each repeated
the same three steps: allocate a shell, set `md->state`, and take the
strong reference to the module through `md_set_module()`. Since #1584
dropped `md->mod`, that last helper no longer set anything, only took a
reference. The new `md_shell_new()` in `dict.h` does all three and
replaces `md_set_module()`. It stays `NOINLINE` for the reason the old
helper gave. The two C API constructors also share one inline body now.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist (no behavior change; the existing
suite covers these paths)
- [x] Documentation reflects the changes (N/A, internal only)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); pending review by @asvetlov
before leaving draft.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` on 3.14.7 (C, 2756 passed), 3.10.17 (C, 2756 passed),
3.14.7t with `MULTIDICT_DEBUG_BUILD=1` (2732 passed); pure Python leg
with `MULTIDICT_NO_EXTENSIONS=1 ... --no-c-extensions` (1296 passed).
Lint: pre-commit (clang-format, ruff, mypy) and `make doc-spelling`
pass.
Wall clock: interleaved pyperf A/B, 6 alternating rounds x 2 processes,
GIL on cpu 1 and free-threaded on cpu 3. An A/A control of base against
itself showed single rows moving up to 7% (GIL) and 4% (fre... (continued)

780 of 1560 branches covered (50.0%)

Branch coverage included in aggregate %.

8164 of 8710 relevant lines covered (93.73%)

1.87 hits per line