brettwooldridge / HikariCP / 2326

76%

push

travis-ci

Cancel HouseKeeper task on pool shutdown (#741)

Periodic house-keeping task is scheduled during construction of
HikariPool. The resulting scheduled task is not stored and therefore it
is not cancelled during pool shutdown.

With standard behaviour, when executor is managed by HikariPool itself,
it is not an issue, because the executor is shut down on pool shutdown.
But when a custom (long running) scheduled executor is supplied via
setScheduledExecutorService, tasks are kept indefinitely causing a
memory leak.

4 of 4 new or added lines in 1 file covered. (100.0%)

1344 of 1754 relevant lines covered (76.62%)

0.77 hits per line