k8snetworkplumbingwg / multus-cni / 35542276437

55%

master: 55%

Pull #1552

github

Fix default route replacement

Multus was failing to detect existing Default routes in container and
remove them before replacement, which causes later adding of default
route to fail with EEXIST, which is ignored and not detected as a error.

This leads to container keeping existing default route in case of
chained CNIs instead of getting new default route from Multus.

Fixes regression introduced by f18d96b64

There was a breaking change in that bump:
https://github.com/vishvananda/netlink/commit/acdc658b8
route.Dst is a zero IPNet instead of nil

Check for default route using isIPNetZero adopted from
github.com/containernetworking/plugins/pkg/ip.IsIPNetZero. Avoid
importing ip.IsIPNetZero to avoid brining more dependencies.

Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>

9 of 9 new or added lines in 1 file covered. (100.0%)

3016 of 5508 relevant lines covered (54.76%)

7.06 hits per line