pulibrary / repecwp / 6153df0e-732c-415e-9ca1-388fa47b1a18

92%

main: 92%

Build Type

Pull #247

circleci

Committed by sandbergja

Commit Message

A few follow-ups:

1. Use Omniauth's built-in CSRF protections, rather than the omniauth-rails_csrf_protection gem:
   you can confirm that the protections still work by attempting to post to /auth/cas without
   an authenticity_token (or with an invalid one) -- it gives you a 500 rather than taking you
   to cas.
2. Use rails `reset_session` as recommended in the Security Rails Guide.
3. Fix a case where an "Edit" button is displayed to users who are not logged in
4. Add some tests
5. Fix some logging lines -- they should be at a debug level, and should use the correct hash keys

Pull Request Pull Request #247: Remove devise

Coverage Stats

52 of 52 new or added lines in 12 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

783 of 851 relevant lines covered (92.01%)

1.75 hits per line