solidjs / solid / 36116708147

74%

main: 89%

push

github

test(compiler): fold dead branches before the tsrx runtime flag scan

tsrx-runtime.test.js has failed 8/10 since #3649 (235173e6a) with
"Runtime bundle still carries build flag(s) __DEV__, __OBSERVE__". A false
positive of the test's own tripwire, not a missing define: that commit made
`setConsoleFooter` a standalone `@solidjs/signals` export that `solid-js`
references from a non-folded `if (IS_DEV)` site, which retains
`signals/src/core/dev.ts` in the test's source-built esbuild bundle. Its
`if (__DEV__ && !__OBSERVE__)` guard becomes `if (false) throw new Error(
"... __DEV__ requires __OBSERVE__ ...")` — esbuild keeps the dead statement
verbatim in unminified output, and the text scan matches the flag names
inside the string literal. Before #3649 the module was tree-shaken away
entirely (`DEV`/`OBSERVE` were only reached through `false ? _DEV : ...`).

Set `minifySyntax: true` on the test bundle so esbuild folds `if (false)` and
dead ternary arms the way rollup does for the real builds; the scan then sees
only code that can run. Verified the tripwire still fires on both halves:
dropping `__OBSERVE__` from `define` fails naming `__OBSERVE__`, dropping the
`"_SOLID_OBSERVE_"` replace fails naming `"_SOLID_OBSERVE_"`.

Shipped dist is unaffected: rollup constant-folds and removes the guard in
every tier; no `__DEV__`/`__OBSERVE__` identifier survives in packages/*/dist.
Compiler Binaries CI did go red on the push of 235173e6a (4 native targets);
it is not a PR check and only runs when packages/compiler/** changes.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

601 of 882 branches covered (68.14%)

Branch coverage included in aggregate %.

883 of 1134 relevant lines covered (77.87%)

25.35 hits per line