Giorgi / DuckDB.NET / 36116707181

88%

push

github

Drop incomplete appender rows instead of flushing them (#355)

CreateRow counts a row as soon as it is created, so a row left with
missing values, for example after an AppendValue threw, was flushed with
uninitialised slots: an access violation for VARCHAR and LIST columns,
and silent junk rows for fixed-width ones.

A row is now written once every column has a value; EndRow is still not
required. Moving on from an incomplete row discards it and faults the
appender, as a failed AppendRow does: the next CreateRow or AppendRow
throws, and the rows completed before it are still written on Close or
Dispose. Close, Dispose and Clear discard an incomplete row without an
error.

A caller can still catch a failed write and append the value again to
finish the row. Writing a value now clears any NULL a failed attempt
left in the same slot, including after the list holding it grows.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KxGp85FzaVDRPo7eXVBFrf

1601 of 1899 branches covered (84.31%)

Branch coverage included in aggregate %.

27 of 27 new or added lines in 3 files covered. (100.0%)

3229 of 3560 relevant lines covered (90.7%)

419753.28 hits per line