pulibrary / repecwp / adb2854b-2763-4009-9c68-a41dc5b7bd3e

92%

main: 92%

Build Type

Pull #247

circleci

Committed by sandbergja

Commit Message

Remove devise

Rather than using a combination of Devise and Omniauth, we can
just user Omniauth by itself.

This:
* simplifies our authentication/authorization to make it a bit
  easier to understand hopefully and a smaller potential
  vulnerability surface.
* means that we only have to worry about one gem while we migrate
  to Entra Id (see #230)
* reduces our dependence on Rails, since Devise has a dependency
  on Rails

The main changes:

* We store the user's session information directly in the Rails
  session, rather than using Devise/Warden to manage that
* Rather than using Devise's `current_user` helper in views,
  we set an ivar `@current_user` and use that instead
* We add our own route and controller for logging out.

Pull Request Pull Request #247: Remove devise

Coverage Stats

30 of 30 new or added lines in 10 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

762 of 830 relevant lines covered (91.81%)

1.72 hits per line