aio-libs / multidict / 36043151885

87%

push

github

Make the underscore prefix mark header-local helpers in _multilib (#1571)

<!-- Thank you for your contribution! -->

## What do these changes do?

Renames the helpers in the `_multilib` headers so that a leading
underscore means exactly "used only within this header". Helpers called
from another header or from `_multidict.c` lose the underscore
(`_md_ensure_key`, `_unicode_hash`, `_str_cmp`, `_update_marks_sync`,
...), and helpers used only in their own header gain one
(`_htkeys_mask`, `_name_is`, `_raise_*`, `_capsule_free`, the
`*1`/`*2`/`*_impl` set operation workers in `views.h`, ...).
`_md_reserve` becomes `md_reserve_for_upd`, since `md_reserve` is
already taken by its wrapper.

Type slots and method callbacks referenced from `PyType_Slot` /
`PyMethodDef` tables keep their names. `GROWTH_RATE` is left as is
(`_GROWTH_RATE` would be a reserved identifier), and so is the unused
`reflist_size()`. Pure rename, no C-level behaviour change; the
pure-Python backend is untouched.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, rename only; the existing
suite covers it
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, C extension, CPython 3.13 GIL: 2647 passed, 115 skipped
Tests, C extension, CPython 3.14t free-threaded: 2635 passed, 127
skipped
Tests, pure Python (`MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions`,
before rebasing onto #1570, no Python files touched): 1268 ... (continued)

778 of 1556 branches covered (50.0%)

Branch coverage included in aggregate %.

7968 of 8480 relevant lines covered (93.96%)

1.88 hits per line