kubernetes-sigs / inference-perf / 36037073528

81%

Build Type

push

github

Committed by web-flow

Commit Message

get_data: add return after each yield-from branch (#692)

Each branch in `get_data()` did `yield from <method>()` then fell
straight through to `raise Exception("Unsupported API type")` once the
generator was exhausted. So even a perfectly normal run ended with that
exception being raised.

Added `return` after each branch. The `raise` at the bottom is still
there as an actual fallback for unknown API types; it just won't get hit
after a valid one anymore.

Related to #100 — the `StopIteration` from that issue was a separate
symptom, but this fall-through was happening on every run regardless.

---

**Rebased onto latest `main`** (resolves the previous merge conflict).
Also cleaned up what a prior rebase left behind:

- Removed the duplicate
`inference_perf/datagen/dataset/hf_sharegpt_datagen.py` that a previous
rebase introduced (the file now lives at
`inference_perf/datagen/dataset/hf_sharegpt_datagen.py` on `main`).
- Preserved the existing context comment referencing #429 in
`get_conversation_turn_content()`.
- No other changes vs. `main` — diff is limited to the `get_data()`
control flow.

Coverage Stats

0 of 5 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

10454 of 12973 relevant lines covered (80.58%)

0.81 hits per line