umputun / tg-spam / 36024115588

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(events): treat anonymous group admin /spam, /ban, /warn as super commands (#455)

* fix(events): treat anonymous group admin /spam, /ban, /warn as super commands

Adjacent to #383 (linked-channel admin gate): when a group admin posts
"as the chat" using Telegram's Send-as-chat toggle, the reply arrives
with `From = GroupAnonymousBot` (fake user, id 1087968824) and
`SenderChat.ID == Chat.ID`. Neither branch of the existing fromSuper
check catches it (SuperUsers lookup on the pseudo-user is false,
isLinkedChannel points at a different chat), so the command falls
through to procEvents where the "skip spam check for anonymous admin
post" branch swallows it silently. Symptom: /spam from the anonymous
admin produces zero action, only DEBUG log at listener.go:412.

The Bot API guarantees this shape is admin-only. From the docs:
- sender_chat: "the supergroup itself for messages sent by its
  anonymous administrators"
- from: "For backward compatibility, if the message was sent on behalf
  of a chat, the field contains a fake sender user in non-channel chats"

So `sender_chat.ID == chat.ID` is a safe admin signal. Added an
isAnonymousGroupAdmin helper next to isLinkedChannel and folded it into
fromSuper. /report is still not a super command, so anonymous /report
now stops at the anonymous-admin skip branch in procEvents (no user
report is filed either — the pseudo-user can never be an approved
reporter).

Tests:
- TestTelegramListener_IsAnonymousGroupAdmin unit-covers the helper
- TestTelegramListener_AnonymousAdminBanSpam drives /ban, /spam, /warn
  through Do() with the exact update shape captured in production
  (verified to fail on master when only the fromSuper wiring is reverted:
  no ban, no spam training, no warning, no delete)
- Existing TestTelegramListener_DoUserReportCommand subtest
  "anonymous admin reply is left alone, not consumed as a report"
  updated: /spam and spam now flow through the super path (delete +
  OnMessage), /report still s... (continued)

Coverage Stats

10 of 10 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

9416 of 11118 relevant lines covered (84.69%)

240.55 hits per line