UI5 / cli / 36011521364

94%

Build Type

push

github

Committed by RandomByte

Commit Message

fix(project): Route theme-library resources in BuildReader

Theme libraries have no namespace and serve their resources under a path owned
by another project, e.g. themelib_sap_horizon serves
/resources/sap/ui/core/themes/sap_horizon/library.css. The previous routing
matched such a path to the sap/ui/core namespace of the sap.ui.core library,
read null there, then requested a reader for every project. That request
(re)builds every non-fresh project, including ones unrelated to the theme.

Replace the single best-guess reader with an ordered list of candidate reader
factories evaluated lazily by byPath, returning the first resource found:

  1. cached readers of already-built projects (free, identifies the owner)
  2. namespace matches, most specific first
  3. theme libraries, when the path has a themes/ segment
  4. the application root project, for non-/resources paths
  5. all projects (last resort)

A reader is requested from the build server only when the preceding candidates
did not yield the resource, so the minimal set of projects is built. The base
theme, owned by sap.ui.core itself, still resolves at the namespace step
without building any theme library.

Coverage Stats

7327 of 8073 branches covered (90.76%)

Branch coverage included in aggregate %.

29 of 30 new or added lines in 1 file covered. (96.67%)

2 existing lines in 1 file now uncovered.

14016 of 14604 relevant lines covered (95.97%)

5298.82 hits per line