safe-global / safe-eth-py / 36000046092

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Raise Etherscan client errors and stop flaky network tests (#2760)

* fix: Raise Etherscan client errors and stop flaky network tests

Etherscan client:
- Detect every rate limit message (per second, daily, free tier) and HTTP 429
  as EtherscanRateLimitError. Before, only "Max rate limit reached" was
  detected and any other error returned None
- Raise EtherscanHttpError for other non ok HTTP responses and
  EtherscanClientException for other API errors, instead of returning None.
  None now only means the contract is not verified
- Wrap transport errors with wrap_http_exceptions as EtherscanConnectionError
- _retry_request raises EtherscanRateLimitError after the last attempt
  instead of returning None

Tests and CI:
- Fix pytest.mark.flaky kwarg: delay is not valid, reruns_delay is
- Add a `network` marker for tests hitting external services (third party
  APIs and RPC nodes). CI only runs them on Python 3.13, so the 4 matrix
  jobs do not share the same API keys at the same time
- Etherscan network tests skip on rate limit, connection and HTTP errors,
  but an invalid API key still fails
- Add offline unit tests for the Etherscan error handling

* fix: Do not retry the Etherscan daily rate limit

- Add EtherscanDailyRateLimitError, raised for the daily quota message.
  _retry_request raises it with no retry, as the quota only resets the next day
- Move the last attempt of _retry_request out of the loop, so there is no
  dead `return None`
- Name the test-app job `test-app (<python version>)`, so it matches the
  required status checks on main. With the `include:` matrix GitHub added
  `not network` to the job name

* fix: Mark only the ENS and Sourcify tests that hit the network

test_domain_hash_to_hex_str and the mocked test_init make no request, so they run on every Python version.

Coverage Stats

172 of 181 new or added lines in 17 files covered. (95.03%)

2 existing lines in 1 file now uncovered.

11649 of 12435 relevant lines covered (93.68%)

3.49 hits per line