umbrellio / rabbit_messaging / 35981731501

93%

push

github

Upgrade to Bunny 3 (#40)

* Upgrade to Bunny 3

Bunny 3 requires Ruby >= 3.2 and adds runtime dependencies on the
openssl (>= 3.3) and logger (>= 1.7) gems. It also needs OpenSSL with
TLS 1.3 support, which Bunny has targeted since 2.20.1.

The private Bunny::Channel internals used by the RabbitExtensions
monkeypatch (@unconfirmed_set_mutex, @only_acks_received and
handle_basic_return) are unchanged in Bunny 3, so publisher confirms
still fail on a returned mandatory message.

Verified against RabbitMQ 4.3.6: a confirm_select publish is delivered
with its properties intact, and a mandatory publish to an unrouted key
raises Rabbit::MessageNotDelivered.

Ruby 3.1 is dropped from the CI matrix for the same reason.

* Fix NoMethodError when headers is explicitly nil

Since 1.8.0 the constructor reads `headers.with_indifferent_access` to
pick up the `compress` flag. The keyword defaults to `{}`, but callers
that pass an explicit `nil` — table_sync's `Publishing::Raw` does, since
it forwards `attributes[:headers]` unconditionally — hit a NoMethodError
on every publish.

* Do not overwrite a queue the subclass already assigned

Since 1.9.0 `inherited` copies the parent queue onto every subclass
unconditionally. A subclass that assigns its own queue from its own
`inherited` hook, before calling `super`, has it silently replaced by the
parent's, and its jobs fall back to the default queue.

Using `||=` keeps the intent of the original change — a subclass without
a queue of its own still inherits the parent's, since its queue is nil at
that point — while leaving an explicitly assigned one alone.

* Retry publishing when Bunny 3 closes the channel on reconnect

Since Bunny 3.1 `Session#handle_network_failure` calls `connection_closed!`
on every channel as soon as it detects a dropped connection, so pooled
channels sit in `:closed` until recovery reopens them.

On 2.x a channel stayed `:open`, the publish reached `send_frameset` and
raised `ConnectionClosedError`... (continued)

91 of 114 branches covered (79.82%)

Branch coverage included in aggregate %.

49 of 51 new or added lines in 4 files covered. (96.08%)

511 of 536 relevant lines covered (95.34%)

13.71 hits per line