move-elevator / typo3-image-compression / 35980247373

91%

push

github

fix: skip non-local FAL storages during compression (#60)

* fix: skip non-local FAL storages during compression

* fix: skip non-local FAL storages during compression

* fix: skip non-local FAL storages instead of building a malformed path

* test: cover non-local storage skip across all compressors

* test: cover non-local storage skip across all compressors

* test: cover non-local storage skip in compressor implementations

* test: cover non-local storage skip in provider compressor tests

* test: cover non-local storage skip in local compressor implementations

* test: cover non-local storage skip in local-tools and local-basic tests

* test: cover non-local storage skip in local-basic compressor

* test: cover non-local storage skip in local-basic tests

* fix: persist compress_error for non-local storage and defer Tinify init

Non-local storage skips in LocalBasicCompressor, LocalToolsCompressor and
TinifyCompressor left compressed=0 with no compress_error, causing the CLI
batch command to reselect and reattempt the same remote-storage files on
every run. The skip now persists a compress_error so the file drops out of
the non-compressed query.

TinifyCompressor::compressProcessedFiles() also called initAction() (which
performs a real API key validation request) before checking whether any
file in the batch was actually on local storage. Initialization is now
deferred until the first local file passes that check.

52 of 52 new or added lines in 4 files covered. (100.0%)

1455 of 1606 relevant lines covered (90.6%)

4.19 hits per line